zeljkoprsa / waterlee-boilerplate

Magento HTML5 Responsive Theme Boilerplate
Creative Commons Zero v1.0 Universal
293 stars 102 forks source link

Using <icon> for font-awesome icons? Why? #69

Closed austinpray closed 9 years ago

austinpray commented 9 years ago

The norm is to use a <i> tag. If for whatever reason <icon> throws the browser a curveball, the user will not be able to close the off-canvas menu.

Propose we remove all instances if <icon> and replace it with <i>

Examples: http://fortawesome.github.io/Font-Awesome/examples/ http://stackoverflow.com/questions/11135261/i-tag-for-icons

Edit: It's also worth noting that the <icon> tag does not exist.