search

zeljkoprsa / waterlee-boilerplate

Magento HTML5 Responsive Theme Boilerplate
Creative Commons Zero v1.0 Universal
293 stars 102 forks source link

Foundation: Is foundation dying out in waterlee? #79

Open ppowalowski opened 9 years ago

ppowalowski commented 9 years ago

Hey,

I wonder if the foundation version of waterlee will be discontinued due to inuit implementation? If so I'd like to ask the users if there is sound demand for future foundation support.

I'm currently working on a foundation based magento site and could imagine to contribute an updated and improved version of waterlee foundation. We may split things up to maintain the choice which version to use without relying on old code. [edit:] also concerning a foundation 6 version in the future

2.0 without foundation suggests that foundation is no longer wished on waterlee.

Thanks for the awesome work so far! :+1: This project really opened my eyes in several ways.

Cheers

ppowalowski commented 9 years ago

Push

groovenectar commented 9 years ago

Also curious here...

zeljkoprsa commented 9 years ago

Hi guys,

Real sorry for this delayed answer. We decided not to go the inuit route. Foundation stays.

Reason is that in order to use inuit, we learned this the hard way, we would need to apply hacks in order to use "inline-block" or have every Magento installation being forced to sport a HTML minify extension.

ppowalowski commented 9 years ago

Hey,

Okay - alright. That means we're back here right? what will happen with the different branches etc.? Someone could create a docker or similar for easier development and than we may start cleaning things up and get back on track. What do you think?

The sass code could use a major rework in some places. A heavier usage of the underlying foundation framework would be deirable. Especially better parametrization by better usage of settings variables and easier maintainable media query implementation like@media #{$medium-up} instantly shoot into my mind.

zeljkoprsa commented 9 years ago

That means we're back here right? - Yes indeed Someone could create a docker or similar for easier development and than we may start cleaning things up and get back on track - No experience with docker but if it helps us open an issue and let's decide on that.

Can we start making a list of improvements right away, like parameterisation and obvious code improvements?

ppowalowski commented 9 years ago

I can make up or participate in an issue of this kind as soon as I have a free mind an some time to extract my thoughts. Great to see things moving :+1:

zeljkoprsa commented 9 years ago

@ppowalowski Me too, lots of great things happening here so we'll pour some of the optimism into this project also :+1:

zeljkoprsa commented 9 years ago

@marjanbonus Started to revise Foundation on wip-1.9. Once he's done and pleased with the work, he'll merge that into master. After that we can continue the work together. Focus is on making the theme as lean as possible.

marjanbonus commented 9 years ago

@groovenectar @ppowalowski wip-1.9 will be merged to master soon so you guys can already check it if you want. It just needs some small fixes on header.. Existing master branch will remain on repository as a secondary branch for users who are on Magento 1.7 or 1.8. Great to hear about participation because we are also short with time. Thanks :+1:

marjanbonus commented 9 years ago

New Waterlee version is up! Wip-1.9 is merged so all of the changes are on master branch.