search

zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
22.05k stars 673 forks source link

Underline colors not working on Window Terminal #3262

Open mmgeorge opened 7 months ago

mmgeorge commented 7 months ago

1. Graphical issue inside a terminal pane (eg. something does not look as it should)

zellij --version: zellij 0.39.2 (I also tried checking out https://github.com/zellij-org/zellij/commit/7f87d93a430a47c82ce3f177a6a2609d3f6abadeand & saw the same thing)

stty size: 56 120

uname -av or ver(Windows): Linux mgeorge 5.15.146.1-microsoft-standard-WSL2 #1 SMP Thu Jan 11 04:09:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Further information

Undercurls are working great, but I seem to be hitting some problems with underline colors in WSL + Window Terminal 1.19/1.20:

echo -e "\x1b[58:5:32m\x1b[4mtest\x1b[59m\x1b[24m" echo -e "\x1b[4:3mTest\x1b[24m "

win-term-default

image

steakhutzeee commented 6 months ago

How undercurls should be enabled for Zellij in Windows Terminal?

I can see them in Neovim on tmux by a terminal override, but not in Zellij.

Any hint?

mmgeorge commented 6 months ago

@steakhutzeee for me they work on the latest version without any additional configuration, just the colors that aren't working for me

steakhutzeee commented 6 months ago

With your commands they work for me too. It's in nvim that they are now working. I was able to let them work inside tmux but not outside with a terminal override. Any idea how to do this with Zellij?

mmgeorge commented 6 months ago

Sorry @steakhutzeee I'm not sure what would be causing them to work in tmux but not zellij. On my end at least they just work by default with the latest zellij.

achkasov commented 6 months ago

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: https://github.com/helix-editor/helix/issues/7065#issuecomment-1740422472

However this does not fix the colored underlines when using Zellij via WinTerm

steakhutzeee commented 6 months ago

Can confirm, works well under WinTerm (after using the tweak below), but not under WinTerm + Zellij.

I had to execute the following line to make the colored underline work (added it to my ~/.zshrc for convenience)

$ set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m'´

Src: helix-editor/helix#7065 (comment)

However this does not fix the colored underlines when using Zellij via WinTerm

This should be tmux config, not zsh. Correct?