Pane frames can get confused, if disabled and enabled.

zellij-org / zellij

A terminal workspace with batteries included

https://zellij.dev

MIT License

22.06k stars 674 forks source link

Pane frames can get confused, if disabled and enabled. #690

Closed a-kenji closed 3 years ago

a-kenji commented 3 years ago

If a bordless pane loses focus, a pane frame gets drawn, if pane frames generally are enabled.

Basic information zellij --version: 0.17.0

Further information Reproduction:

Start zellij --layout-path [TEMPLATE] with the following layout template:

---
template:
direction: Horizontal
parts:
- direction: Vertical
  borderless: true
  split_size:
    Fixed: 1
  run:
    plugin: tab-bar
- direction: Vertical
  borderless: true
- direction: Vertical
  borderless: true
  split_size:
    Fixed: 2
  run:
    plugin: status-bar

Gif: borderless

imsnif commented 3 years ago

@a-kenji - I also fixed this in main :) could you please confirm?

a-kenji commented 3 years ago

@imsnif This is much better now and itself it is fixed, but I think both of the issues you fixed together still have an interesting interaction:

the layout used here is:

---
template:
  direction: Horizontal
  parts:
    - direction: Vertical # part 1
      borderless: true
    - direction: Vertical # part 2
      borderless: true
      split_size:
        Fixed: 1
      run:
        plugin: tab-bar

a-kenji commented 3 years ago

@imsnif Nvm, that is just a problem on kitty for me atm, it doesn't seem to be the interaction together. So this issue is fixed!