zellij-org / zellij

A terminal workspace with batteries included
https://zellij.dev
MIT License
22.04k stars 673 forks source link

Issue in closing tab #781

Closed jaeheonji closed 3 years ago

jaeheonji commented 3 years ago

Basic information

zellij --version: zellij 0.19.0 tput lines: 68 tput cols: 296 uname -av or ver(Windows): Darwin XXX-MacBookAir.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:20 PDT 2021; root:xnu-7195.141.6~3/RELEASE_ARM64_T8101 arm64 iterm2 --version: Build 3.4.10

Further information

Hi! I recently discovered a few strange things while testing on the latest sources.

In my environment, occurred following issue:

If this is an issue that only occurs to me or is already being worked on, I will close the issue.

Additionally, I attached log file. zellij.log

imsnif commented 3 years ago

Hey @jaeheonji - unfortunately opening tabs in the development environment is SUPER slow. When I need to debug things that have to do with tabs I usually go to make myself some coffee while it's happening :)

This is a painful issue that we're aware of and definitely intend to solve in the near future.

I don't know about the second issue though - does this happen while you're waiting for the tab to open?

jaeheonji commented 3 years ago

Thanks for the quick comment! @imsnif

in second, occurs when trying to close (CTL+T, X) a created tab or an existing tab after creating a new tab (CTL+T, N).

EDIT: in the development environment

EDIT2: There are only 2 lines left in the log

INFO   |zellij_server::wasm_vm   | 2021-10-14 17:34:58.072 [wasm      ] [zellij-server/src/wasm_vm.rs:148]: Bye from plugin 2
INFO   |zellij_server::wasm_vm   | 2021-10-14 17:34:58.074 [wasm      ] [zellij-server/src/wasm_vm.rs:148]: Bye from plugin 3
imsnif commented 3 years ago

Good find!!

This is just in main and not released yet, so things sometimes happen there :) I'm touching this area as part of a different change, so will fix it. Too bad we don't have a test for this :/

ev-agelos commented 3 years ago

Same freeze happens to me when i type exit in the terminal (i use also the main branch), the terminal only freezes, i closed it and open a new terminal and attached to the session and the tab as expected wasnt there.

imsnif commented 3 years ago

Same freeze happens to me when i type exit in the terminal (i use also the main branch).

Of that I'm aware yeah. My apologies for it. Generally the main branch is used for development and not recommended for anything else, I'm afraid. We can't guarantee that it'll always be unbroken

ev-agelos commented 3 years ago

Of that I'm aware yeah. My apologies for it. Generally the main branch is used for development and not recommended for anything else, I'm afraid. We can't guarantee that it'll always be unbroken

Sure I understand I wanted to use the main cause i gained a little bit of time with your last fixes than waiting the release :)

imsnif commented 3 years ago

Cool - I hope to have everything stable and released soon!

jaeheonji commented 3 years ago

Good find!!

This is just in main and not released yet, so things sometimes happen there :) I'm touching this area as part of a different change, so will fix it. Too bad we don't have a test for this :/

Great! If you're already working on this, It seems good to close this issue. Instead, it is better to create an enhancement issue that writes test cases related to this content.