zen-browser / desktop

🌀 Experience tranquillity while browsing the web without people tracking you!
https://zen-browser.app
Mozilla Public License 2.0
19.47k stars 470 forks source link

Unsetting some keyboard shortcuts causes the application to get stuck in the splash screen. #2664

Open Iliano101 opened 3 weeks ago

Iliano101 commented 3 weeks ago

Captchas

What happened?

Actual result

Unsetting the keyboard shortcut 'Go Back' or 'Go Forward' causes the application to get stuck in the splash screen.

Expected result

Any keyboard shortcut can be unset without breaking the application.

Steps to reproduce

  1. Launch the application.
  2. Open the settings.
  3. Go to the 'Keyboard Shortcuts' tab.
  4. Scroll down to the 'Navigation' section.
  5. Unset the keyboard shortcut 'Go Back' or 'Go Forward' by pressing 'Backspace'.
  6. Press 'Escape' to save.
  7. Close the application.
  8. Reopen the application.
  9. Notice that the application is now stuck on the splash screen.

Notes

Attachments

Affected shortcuts : short

Result after steps to reproduce : splash

Reproducible?

Version

1.0.1-a17

What platform are you seeing the problem on?

Windows

Relevant log output

No response

dosubot[bot] commented 3 weeks ago

Hey @Iliano101! I'm here to help you with any bugs, questions, or contributions you need assistance with. Let's work together to resolve your issue.

There are no specific issues or discussions directly related to the splash screen getting stuck due to unsetting keyboard shortcuts like 'Go Back' or 'Go Forward'. However, there are known issues with keyboard shortcuts in general, such as the ones mentioned in the closed issues Keyboard shortcuts broken and Default Keyboard Shortcuts Don't work on Windows. These issues were resolved by updating to version 1.0.1-a.10 [1][2].

The application handles unset or null keyboard shortcuts by clearing the keybind if both shortcut and modifiers are not provided [3]. This might be related to the issue you're experiencing, as unsetting certain shortcuts could potentially lead to unexpected behavior during startup.

Additionally, there is error handling for keyboard shortcut configurations during startup, which logs errors and resets shortcuts to defaults if parsing fails [3]. This might not directly address the splash screen issue, but it indicates that the application has mechanisms to handle errors related to shortcuts.

Given the issue you're facing, it might be worth checking if there are any error logs generated during startup that could provide more insight into why the application is getting stuck.

To continue talking to Dosu, mention @dosu.

Iliano101 commented 3 weeks ago

@dosu, Where can I find the logs/errors on startup ?

dosubot[bot] commented 3 weeks ago

You can find the logs and errors on startup by checking the console output or log files generated by the application. Typically, these logs are located in the application's profile or data directory. On Windows, you might find them in a path like C:\Users\<YourUsername>\AppData\Roaming\<ApplicationName>\logs. Look for files with names like error.log or debug.log. If the application provides a built-in console or developer tools, you can also check there for any error messages during startup.

To continue talking to Dosu, mention @dosu.