zen-browser / surfer

Simplifying building firefox forks!
Mozilla Public License 2.0
74 stars 9 forks source link

Feature Request: Option to Disable Automatic Update Check #6

Open Vinetos opened 1 month ago

Vinetos commented 1 month ago

Hey !

I wanted to propose a feature that could benefit users, particularly those using Nix: an option to disable the automatic update check in the custom browser.

For users building Firefox forks with Nix, the ability to disable automatic updates can streamline the build process, as the Nix ecosystem ensures consistent versioning. This would also allow us to maintain a good "runtime environment" without interruptions from update prompts.

I was thinking of adding an environment variable for this feature. Do you think that would be the best approach, or do you have other ideas in mind?

I’m happy to contribute to implementing this feature if you let me know your preferred approach.

Best,

everyx commented 3 weeks ago

It may be possible to adjust the priority of customConfig so that it can override internalMozconfg ?

  const mergedConfig =
    `# This file is automatically generated. You should only modify this if you know what you are doing!\n\n` +
    commonConfig +
    '\n\n' +
    osConfig +
    '\n\n' +
-   customConfig +
-   '\n' +
-   internalMozconfg(brandingKey, dynamicConfig.get('buildMode'))
+   internalMozconfg(brandingKey, dynamicConfig.get('buildMode')) +
+   '\n' +
+   customConfig