search

zenangst / Vaccine

:syringe: Vaccine - Make your apps immune to recompile-disease
Other
307 stars 18 forks source link

Improve handling of UITabBarControllers and UINavigationControllers #16

Closed zenangst closed 6 years ago

zenangst commented 6 years ago

UINavigationController and UITabBarController should not remove their child view controllers as that empties out their view stacks. Instead, UINavigationController should opt out from that behavior and UITabBarController can set the view controllers using an empty array so that viewDidLoad will set up new view controllers.

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will decrease coverage by 0.13%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #16      +/-   ##
=========================================
- Coverage   70.33%   70.2%   -0.14%     
=========================================
  Files          17      17              
  Lines         391     396       +5     
=========================================
+ Hits          275     278       +3     
- Misses        116     118       +2
Impacted Files Coverage Δ
Source/iOS+tvOS/UIViewController+Extensions.swift 94.73% <66.66%> (-5.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cd5b24...91a33e8. Read the comment docs.