search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

add SECRET_PULLER_TYPE to migrate to secret-sidecar #4032

Closed rbayerl closed 2 years ago

rbayerl commented 2 years ago

Modify init container when SECRET_PULLER_TYPE is set to secret-sidecar.

Risks

rbayerl commented 2 years ago

Any idea what these failed GitRepository checks are all about? They seem unrelated to my change.

grosser commented 2 years ago

bundle_audit regularly fails but that's not your fault

grosser commented 2 years ago

GitRepository should not fail ... but I can take a look if you can reproduce

rbayerl commented 2 years ago

It's weird the tests seem flaky...e.g. test sqlite one of my tests pass but it fails on mysql and postgres. All of them have the GitRepository failure.

grosser commented 2 years ago

new to me and passes locally ... so just add a skip 😞

rbayerl commented 2 years ago

Not sure I'm following. It's been a while since I did anything with rspec 😅

grosser commented 2 years ago 
skip "Somehow broken on CI" if ENV["CI"]
grosser commented 2 years ago

let me fix them all in https://github.com/zendesk/samson/pull/4033#pullrequestreview-1171043289 and then you can have a clean PR :)

grosser commented 2 years ago

rebase 🤞

grosser commented 2 years ago

pushed a fix