zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

allow not setting replicas for deployments #4057

Closed grosser closed 1 year ago

grosser commented 1 year ago

ideally that would be automatic, but that could break lots of things ... so using a flag to opt-in instead

also: cleaning up support for ShardedDeployment since that is EOL

Risks

grosser commented 1 year ago

had to also add that server-side-apply is enabled or this ends up setting 1, since that's the replica default when using "replace" workflow