zendesk / ticket_redaction_app

Other
9 stars 5 forks source link

Not fully redacted #60

Closed lherlitz closed 7 years ago

lherlitz commented 7 years ago

When using the redaction, it's not redacting the HTML version of the origianl email, only the text version.

dpawluk commented 7 years ago

@lherlitz can you elaborate what you mean by this? Is information in the ticket not redacted?

lherlitz commented 7 years ago

That’s correct. When viewing the original email from within zendesk, the redacted text is still visible.

Sent from my iPhone

On Sep 25, 2017, at 4:48 PM, Daniel Pawluk notifications@github.com wrote:

@lherlitz can you elaborate what you mean by this? Is information in the ticket not redacted?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

dpawluk commented 7 years ago

I see. In that case the functionality is unrelated to the app. I would suggest contacting Zendesk regarding the redaction API itself and asking for them to extend the functionality so that these files are included in the redaction functionality provided by the API. The App just uses the API provided by Zendesk and so has no control over "how" things are redacted on the back end.

lherlitz commented 7 years ago

¯_(ツ)_/¯ they told me to tell you. I didn’t build the app and I really don’t want to be the middle man. You and they are now both aware there is a problem. I’ll leave it up to y’all to figure out who wants to fix it.

On Sep 26, 2017, at 1:12 PM, Daniel Pawluk notifications@github.com wrote:

I see. In that case the functionality is unrelated to the app. I would suggest contacting Zendesk regarding the redaction API itself and asking for them to extend the functionality so that these files are included in the redaction functionality provided by the API. The App just uses the API provided by Zendesk and so has no control over "how" things are redacted on the back end.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332287158, or mute the thread https://github.com/notifications/unsubscribe-auth/AQgU5rqStfuLg-uFsA-1jgxsZYLRd-Gvks5smT6mgaJpZM4Ovg62.

dpawluk commented 7 years ago

I appreciate that. I also appreciate your time. Any chance you can give me the ticket number you had for this so I can reference it when discussing please? Thanks in advance for the extra info!

On Tue, Sep 26, 2017 at 1:15 PM lherlitz notifications@github.com wrote:

¯_(ツ)_/¯ they told me to tell you. I didn’t build the app and I really don’t want to be the middle man. You and they are now both aware there is a problem. I’ll leave it up to y’all to figure out who wants to fix it.

On Sep 26, 2017, at 1:12 PM, Daniel Pawluk notifications@github.com wrote:

I see. In that case the functionality is unrelated to the app. I would suggest contacting Zendesk regarding the redaction API itself and asking for them to extend the functionality so that these files are included in the redaction functionality provided by the API. The App just uses the API provided by Zendesk and so has no control over "how" things are redacted on the back end.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332287158>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AQgU5rqStfuLg-uFsA-1jgxsZYLRd-Gvks5smT6mgaJpZM4Ovg62 .

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332287632, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBT0x1aX_fKjOOXrjdMRKE6dlMlft3Uks5smT8TgaJpZM4Ovg62 .

-- Daniel Pawluk Developer Relations Manager

Zendesk http://www.zendesk.com/

lherlitz commented 7 years ago

I don’t recall that, I’m afraid.

On Sep 26, 2017, at 4:05 PM, Daniel Pawluk notifications@github.com wrote:

I appreciate that. I also appreciate your time. Any chance you can give me the ticket number you had for this so I can reference it when discussing please? Thanks in advance for the extra info!

On Tue, Sep 26, 2017 at 1:15 PM lherlitz notifications@github.com wrote:

¯_(ツ)_/¯ they told me to tell you. I didn’t build the app and I really don’t want to be the middle man. You and they are now both aware there is a problem. I’ll leave it up to y’all to figure out who wants to fix it.

On Sep 26, 2017, at 1:12 PM, Daniel Pawluk notifications@github.com wrote:

I see. In that case the functionality is unrelated to the app. I would suggest contacting Zendesk regarding the redaction API itself and asking for them to extend the functionality so that these files are included in the redaction functionality provided by the API. The App just uses the API provided by Zendesk and so has no control over "how" things are redacted on the back end.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332287158>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AQgU5rqStfuLg-uFsA-1jgxsZYLRd-Gvks5smT6mgaJpZM4Ovg62 .

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332287632, or mute the thread https://github.com/notifications/unsubscribe-auth/AFBT0x1aX_fKjOOXrjdMRKE6dlMlft3Uks5smT8TgaJpZM4Ovg62 .

-- Daniel Pawluk Developer Relations Manager

Zendesk http://www.zendesk.com/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zendesklabs/ticket_redaction_app/issues/60#issuecomment-332335901, or mute the thread https://github.com/notifications/unsubscribe-auth/AQgU5k4DrdJzdkU77jMfCyvVkYBAt9IMks5smWcAgaJpZM4Ovg62.

dpawluk commented 7 years ago

@lherlitz I'll do my best without, however, feel free to post back here if you end up being able to find it after searching your email for the phrase 'redact' or something. Thanks again