search

zendesk / zendesk_api_client_rb

Official Ruby Zendesk API Client
http://developer.zendesk.com/
Apache License 2.0
387 stars 184 forks source link

Refactor Side Load of `ZendeskAPI::Association` Into A Separate Object #555

Open khezam opened 1 year ago

khezam commented 1 year ago

It seems like the side load behaviors of the ZendeskAPI::Association class could be encapsulated in a separate object for extendability so I thought it might be a good opportunity to refactor.

Let me know if it's not needed and I'm happy to close this PR.

ecoologic commented 1 year ago

Hi @khezam - thank you for another contribution! (your previous one is coming, I just need another internal review).

We don't have much time at present to do a deep review on it, but eventually we'll find the time.

First question: Is this code already covered by existing tests or would it benefit from extra testing?

Thanks again ❤️

khezam commented 1 year ago

Hi @ecoologic - my pleasure and I'm happy I could help :)

We don't have much time at present to do a deep review on it, but eventually we'll find the time.

No worries at all and I totally understand that.

First question: Is this code already covered by existing tests or would it benefit from extra testing?

Yes, this code is already covered by existing tests :)