Enable use of MetadataFeature with TableIdentifier

[jbelien]

Fix #391

Provide a narrative description of what you are trying to accomplish:

• [x] Are you fixing a bug?
  • [x] Detail how the bug is invoked currently (see #391).
  • [x] Detail the original, incorrect behavior (see #391).
  • [x] Detail the new, expected behavior (see #391).
  • [x] Base your feature on the master branch, and submit against that branch.
  • [x] Add a regression test that demonstrates the bug, and proves the fix.
  • [ ] Add a CHANGELOG.md entry for the fix.

[jbelien]

@webimpress Sure, I probably can do that but never tried to add a test on a ZendFramework project.

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in https://github.com/zendframework/zend-db/blob/master/test/unit/TableGateway/Feature/MetadataFeatureTest.php ?

[michalbundyra]

@jbelien Cool! If you have any questions you can catch me on ZF slack

[jbelien]

@webimpress I apparently can't join the ZF Slack. When I try to login, it says that "I need to ask the workspace admin to invite me." (edit: fixed, invite via https://zendframework-slack.herokuapp.com/).

You didn't reply my question:

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in TableGateway/Feature/MetadataFeatureTest.php ?

Thanks!

[michalbundyra]

@jbelien sorry, to join the slack you have to follow this link: https://zendframework-slack.herokuapp.com

Do I "just" have to add a new test that uses MetadataFeature with TableIdentifier in https://github.com/zendframework/zend-db/blob/master/test/unit/TableGateway/Feature/MetadataFeatureTest.php ?

Yes, that's correct, as you are modifying MetadataFeature.php tests should be added in the corresponding test class.

[jbelien]

Thank you so much @webimpress for your help! ❤️

[michalbundyra]

Thanks, @jbelien!