fix prototype for PHP 7.2

zendframework / zend-router

Standalone routing implementation for HTTP and console requests

BSD 3-Clause "New" or "Revised" License

32 stars 20 forks source link

fix prototype for PHP 7.2 #39

Closed remicollet closed 6 years ago

remicollet commented 6 years ago

Discovered in Fedora QA with PHP 7.2.0RC4 https://apps.fedoraproject.org/koschei/package/php-zendframework-zend-router?collection=f28

PHP Fatal error: Declaration of ZendTest\Router\Http\TestAsset\DummyRouteWithParam::match(Zend\Stdlib\RequestInterface $request) must be compatible with ZendTest\Router\Http\TestAsset\DummyRoute::match(Zend\Stdlib\RequestInterface $request, $pathOffset = NULL) in /builddir/build/BUILD/zend-router-03763610632a9022aff22a0e8f340852e68392a1/test/Http/TestAsset

coveralls commented 6 years ago

Coverage remained the same at 87.242% when pulling 27a4b8310cd8fd968d25ab7ee61798a279f87601 on remicollet:issue-php72 into 0a537767b428d3c93c1fa197a5d34c1d5ef63d23 on zendframework:master.