Make venv.sh create a python3 virtualenv

zenhack / simp_le

Simple Let's Encrypt client

GNU General Public License v3.0

224 stars 38 forks source link

Make venv.sh create a python3 virtualenv #125

Closed haydngreatnews closed 5 years ago

haydngreatnews commented 5 years ago

Also, completely switch to python3 in bootstrap.sh

v0.15 officially drops support for python2, but most Debian-like LTS-style systems will still have it installed and default to it when using virtualenv. This way we can be sure that the provided install path will be running on python3

This PR doesn't address the yum world, as python3 doesn't seem to be in core, and I don't have the background to know what the standard install path for it is there.

Also closes #21

zenhack commented 5 years ago

Thanks for the patch. This looks basically reasonable, but right now I don't have a debian system set up, so I need to fix that in order to test; I'll find time for that soonish.

julienw commented 5 years ago

I tried the patch locally and it worked for me (Debian Buster quite uptodate). What I did

manually installed the packages from bootstrap.sh (I didn't run the script directly)
tried venv.sh both over a preexisting python2 venv and after rm-ing venv. In both situations I could launch simp_le properly.

Note: my certs were uptodate so I couldn't run the full process.

zenhack commented 5 years ago

Looks good, merging. Sorry for the delay.