zeph-yr / JDFixer

Allows automated forcing of jump distance (JD) across maps. And now Reaction Time too.
https://www.xephai.com
GNU Affero General Public License v3.0
36 stars 17 forks source link

Offset based snapping doesn't actually "fix" the offset of a map. #15

Open Mawntee opened 1 year ago

Mawntee commented 1 year ago

When a chart uses a base game offset of something like 0, 0.25, 0.5, etc the note will always spawn and jump up on the whole/half/quarter beat respectively.

If you are basing the snapping of of the charts default offset set by the mapper, it's not always going to be these values and will often end up snapping off beat/off time.

In this example, the mapper had set the offset to -0.75, which when snapped to a quarter beat will sync up the note spawn animation perfectly. (look at the spawn light on the bottom view) https://streamable.com/u466cd

But here, the mapper had set the offset of the song to -0.7. All of the snapping options for this map leave the spawn animation of the note off-time with the music. https://streamable.com/qj8z42 https://streamable.com/yzmukf

If there is any way to set the offset of the chart to the nearest selected snapping value (1/8, 1/4, 1/2, etc) before actually snapping things, that would be ideal.

This is a very subtle thing that isn't something people immediately notice, but it's one of those niche background things that can make a map either feel very satisfying, or very awkward/hard to time

Mawntee commented 20 minutes ago

Bump!

It would be really nice to have this work as intended, since it otherwise completely defeats the purpose of having any snapping at all.