zephyrproject-rtos / zephyr

Primary Git Repository for the Zephyr Project. Zephyr is a new generation, scalable, optimized, secure RTOS for multiple hardware architectures.
https://docs.zephyrproject.org
Apache License 2.0
10.59k stars 6.48k forks source link

Stack size revert in `samples/philosophers` break some in-tree boards #55040

Closed fkokosinski closed 1 year ago

fkokosinski commented 1 year ago

Describe the bug Found with Renode while working on Renodepedia.

Changes introduced in #54969 break the Dining Philosophers demo for the following in-tree platforms:

To Reproduce Build and flash (or upload the sample by other means) the sample: west build -p -b <board_name> samples/philosophers

Expected behavior Philosopher statuses should be printed out.

Impact The demo doesn't work properly.

Logs and console output The demo freezes after printing the demo description section; no output for philosophers with STACK_SIZE=1024:

Demo Description
----------------
An implementation of a solution to the Dining Philosophers
problem (a classic multi-thread synchronization problem).
This particular implementation demonstrates the usage of multiple
preemptible and cooperative threads of differing priorities, as
well as dynamic mutexes and thread sleeping.

Environment (please complete the following information):

carlocaione commented 1 year ago

@SakuRautio-ext FYI

SakuGlumoff-ext commented 1 year ago

I think the commit should be reverted and we can investigate the issue further internally.