[Bug 🐞]: Duplicate Tanks and Name Issues

zer0Kerbal / SimpleConstruction

Provides simple craft building capability in flight mode to stock parts for Kerbal Space Program.

https://forum.kerbalspaceprogram.com/index.php?/topic/191424-*/

GNU General Public License v3.0

6 stars 7 forks source link

[Bug 🐞]: Duplicate Tanks and Name Issues #114

Closed hutiwephy closed 2 years ago

hutiwephy commented 2 years ago

Brief description of your issue

There are duplicate ore tanks which names either end in ´´´(Ore)´´´, ´´´(Metal)´´´ or ´´´(RocketParts)´´´,

There is also an Issue with the Ore Material variant name being ´´´#autoLOC_501007 = Ore´´´ instead of Ore

Steps to reproduce

Install the mod Acoording to Instructions

Expected behavior

No duplicates and correct names

Actual behavior

Good behaviour with minor issues

Environment

Mod: SimpleConstruction-4.0.99.6-prerelease-CF
KSP: 1.12.3
Download: Github

How did you download and install this?

GitHub release .zip (advanced manual installation)

github-actions[bot] commented 2 years ago

Thank you. Kindly read contributiing.md, code_of_conduct.md and styleguide.md. These are boilerplate.

zer0Kerbal commented 2 years ago

Thank you @hutiwephy !

So I see two issues:

a localization issue (easy fix)
duplicate parts issue.

Need to know more about your setup:

what is also installed in your game
did you do a clean install?

zer0Kerbal commented 2 years ago

Do you have B9PartSwitch installed?

zer0Kerbal commented 2 years ago

Update: @hutiwephy

first issue is resolved. Just needed to add // (comment out) the last word "ore"; will work. again thank you.

second issue: I suspect that you have B9PS installed - so you don't want to see the stock tanks as well.

Considerations

Can't remove them because what happens if B9PS is removed or fails?
Or if a player adds B9PS after they have launched craft with say a RocketParts tank.

Will think it over while waiting for your response.

hutiwephy commented 2 years ago

A possible solution for the second one is to make a optional config file that deletes the duplicates

zer0Kerbal commented 2 years ago

A possible solution for the second one is to make a optional config file that deletes the duplicates

@hutiwephy excellent suggestion!

I am probably going to add in another ghostparts.cfg - just for B9PS; so if B9PS is installed it will 'hide' the additional tanks (hidden in editors, does not affect parts already in flight)

zer0Kerbal commented 2 years ago

after futher consideration, will not need an additional config file; rather can/will build the 'ghosting' into the original patch.

zer0Kerbal commented 2 years ago

@hutiwephy below find a zip file

Kindly try these two files (B9TanksSwitch.cfg and Tanks.cfg) that are in the archive file in their correct places. Should just be able to drag the directories (or files) and replace existing.

unpack here: <KSP_ROOT>/GameData/SimpleConstruction

I make no warranty (have to say that) however they shouldn't damage anything - still make a backup or your save or test on a blank save first. This should make those extra parts be 👻 's in the editors, but still available in flight so no ships should be damaged in the making of this release.

SimpleConstruction.zip

zer0Kerbal commented 2 years ago

my testing shows both issues resolved. Again @hutiwephy thank you!

please let me know how it works for you now. 🆕

hutiwephy commented 2 years ago

It's also working with me as well no further issues to report

zer0Kerbal commented 2 years ago

It's also working with me as well no further issues to report

Thank you @hutiwephy for the feedback! Both the original and the last. Plus the stuff 🥙 in the middle!

Glad to hear this!

Happy 💥 , wait.. I meant to say 🛸 and 🏗️ !