search

zero-to-mastery / WebBlocks

zero-to-mastery re-usable web component library.
https://zero-to-mastery.github.io/WebBlocks/
MIT License
22 stars 60 forks source link

Hero component #6

Closed r4pt0s closed 3 years ago

r4pt0s commented 3 years ago

Each website usually has a here section at the very top of it. This component should at least receive breakpoints as props, maybe a default background color and how much of a height it should take and a image url. Then it should receive content via slots.

Kenny-Vu commented 3 years ago

Hi, I'd like to give it a shot if no one is doing it yet :)

r4pt0s commented 3 years ago

@Kenny-Vu Go for it 💪🏻

Kenny-Vu commented 3 years ago

Hi @r4pt0s,

Currently having a problem with the build, so I haven't even seen how the project looks like. Googled around to read about the bugs and seems like a very recent issue. If you have time and an idea to help me fix this that would be really appreciated. Otherwise, you can remove me from the task and I'll hop on another HacktoberFest project no worries :)

ztm-error 0

r4pt0s commented 3 years ago

@Kenny-Vu,

When does this happen? If you npm start the project?

Or did you already add something and the error got thrown then?

Kenny-Vu commented 3 years ago

After npm start. Haven't added anything yet. Only npm installed.

r4pt0s commented 3 years ago

Okay. I'll have to look into it.

If you want to move on, let me know about it.

Kenny-Vu commented 3 years ago

Yes, you can remove me no problem. Thanks!

pawankm21 commented 3 years ago

Would like to work on this issue.

r4pt0s commented 3 years ago

@pawankm21 Go for it 💪🏻

pawankm21 commented 3 years ago

On it.

pawankm21 commented 3 years ago

Hey, should I create props for each breakpoint or one prop for all?

r4pt0s commented 3 years ago

One for all would be enough.