search

zeromq / libzmq

ZeroMQ core engine in C++, implements ZMTP/3.1
https://www.zeromq.org
Mozilla Public License 2.0
9.8k stars 2.36k forks source link

Problem: CI build android on ubuntu-latest failed #4726

Closed githejie closed 3 months ago

githejie commented 3 months ago

Solution: Fixed the NDK version to android-ndk-r25 to avoid using unsupported NDK version on ubuntu-latest.

Fixes #4725

stephan57160 commented 3 months ago

I think I modified this variable initialization, to allow NDK configuration, as per development need. Temporarily, this (or something similar) should help : 

export NDK_VERSION=android-ndk-r25c
export ANDROID_NDK_ROOT=<my_prefered_ndk_root>
./ci_build.sh

Given NDK will/should be downloaded automatically during the build, if not already available. At least, this was the goal...

I add @benjdero, as he might have some other fix pending for another issue with NDK 25.

stephan57160 commented 3 months ago

See this : https://github.com/zeromq/libzmq/tree/master/builds/android#android-ndk

githejie commented 3 months ago

Hi @stephan57160, thanks for your comment.

I previously specified the NDK version in ci_build.sh because I thought ci_build.sh was specifically for GitHub action, and users would use build.sh for local builds.

After considering your comment, I think it is more reasonable to use environment variables in CI.yaml to specify the NDK version.

stephan57160 commented 3 months ago

I previously specified the NDK version in ci_build.sh because I thought ci_build.sh was specifically for GitHub action, and users would use build.sh for local builds.

It was like this previously, yes. But it was a nightmare to have ZYRE, CZMQ and LIBZMQ in sync regarding NDK versions.

benjdero commented 3 months ago

This seems to be the right solution 👍