search

zeromq / zmqpp

0mq 'highlevel' C++ bindings
http://zeromq.github.io/zmqpp
Mozilla Public License 2.0
439 stars 195 forks source link

SOCKET no longer defined since winsock2.h removed from zmq.h #233

Open Dysl3xik opened 4 years ago

Dysl3xik commented 4 years ago

If you try to build this library with a newer release of ZeroMQ, on a windows box, you get errors because SOCKET can't be resolved in compatability.h.

This was introduced in this merge I believe: zeromq/libzmq#3681

I will submit a PR that introduces the same fix into this code base as was proposed in that one.

nilsmelchert commented 3 years ago

Thanks for the PR in advance. Did you manage to compile zmqpp on windows?

Dysl3xik commented 3 years ago

It worked fine with my fix applied, I didn't re-pull after it was merged though, but I would assume it was fine and this can be closed.