Duplicates

[rlpowell]

So a bunch of us are using this at my work, and some of us (especially the people using irssi) pretty regularily get duplicated messages, where each campfire message will get sent to us 2 or more times (I've seen as much as five).

-Robin

[zerowidth]

Do you have the most recent versions of all the gems involved? I saw this occasionally when using this a year or so ago, but wasn't able to reliably reproduce it.

[alindeman]

I observed this after /parting a channel (room) and rejoining it later.

[mdz]

I see this regularly as well. I'm using camper_van via an IRC proxy (bip), which is always connected to it, but I regularly disconnect and reconnect from IRC clients.

I'm using current camper_van from git and current versions of all gems

[technomancy]

I can confirm that this is caused by /part not being honored.

[mdz]

I think the issue is actually due to JOIN being honored for channels which we're already in. I made a naive attempt at a fix and it seems to have worked.

[alindeman]

Are you going to make a pull request with it?

Andy Lindeman Sent from a mobile device. Please excuse the brevity and top reply.

On Tuesday, August 7, 2012 at 20:13, Matt Zimmerman wrote:

I think the issue is actually due to JOIN being honored for channels which we're already in. I made a naive attempt at a fix and it seems to have worked.

— Reply to this email directly or view it on GitHub (https://github.com/aniero/camper_van/issues/15#issuecomment-7571360).

[zerowidth]

Thanks for digging into this, guys! @mdz if you have a patch, even if it's hacky, I'd take a look at it.

[mdz]

It's linked above: https://github.com/aniero/camper_van/issues/15#commits-ref-48594da

On Wed, Aug 08, 2012 at 06:59:18AM -0700, Nathan Witmer wrote:

Thanks for digging into this, guys! @mdz if you have a patch, even if it's hacky, I'd take a look at it.

---

Reply to this email directly or view it on GitHub: https://github.com/aniero/camper_van/issues/15#issuecomment-7584266

• mdz

[zerowidth]

@mdz thanks for the patch, I didn't see it earlier. I think I've solved it at a lower level, preventing the basic message stream from being started twice. I left the channel join alone so irc clients can get an updated user list and topic still on a second join.

Let me know if my patch fixes it -- it's in the bugfix/multiple_joins branch.

[mdz]

I backed out my fix, and applied yours, and now I have duplicates again. Unfortunately it looks like it doesn't fix the problem (at least for me).

On Thu, Aug 09, 2012 at 04:55:35AM -0700, Nathan Witmer wrote:

@mdz thanks for the patch, I didn't see it earlier. I think I've solved it at a lower level, preventing the basic message stream from being started twice. I left the channel join alone, so irc clients can get an updated user list and topic still on a second join.

Let me know if my patch fixes it -- it's in the bugfix/multiple_joins branch.

---

Reply to this email directly or view it on GitHub: https://github.com/aniero/camper_van/issues/15#issuecomment-7612069

• mdz

[alindeman]

Did not fix duplicates for me either.

[zerowidth]

There's still a bug in my code, but I'm also having a hell of a time with EventMachine. Doesn't seem the streaming requests to the campfire API are being closed on request, and I'm still trying to figure out why. Once I figure that out, I'll be able to fix this properly!

[alindeman]

Thanks @aniero!

[zerowidth]

Alright, I'm punting on it. Don't know what's broken with EM / em-http-request, but they're older versions of the libraries anyway. I've pushed a new version of camper_van that has a modified version of @mdz's fix, plus what I tried before. It's not ideal, since it relies on correct behavior from irc clients when it sends messages for channels you're no longer supposed to be in, but it should work!