zerowidth / camper_van

A Campfire to IRC bridge
MIT License
129 stars 25 forks source link

Fix for EM/em-http-request close_connection #44

Closed tleish closed 11 years ago

tleish commented 11 years ago

If the em-http-request gem is installed, it will take presidence for the HTTP connection over the EventMachine. It does not have a .close_connection method, but rather a .close and throws an error when closing an IRC client

See: camper_van issue #40 https://github.com/zerowidth/camper_van/issues/40

em-http-request https://github.com/igrigorik/em-http-request/blob/master/lib/em-http/http_connection.rb#L172-201

zerowidth commented 11 years ago

Good catch, and thanks for fixing this! :metal:

lovek323 commented 11 years ago

Nice work. Thanks. :smile: