zesterer / ariadne

A fancy diagnostics & error reporting crate
https://crates.io/crates/ariadne
MIT License
1.61k stars 72 forks source link

Removing magic numbers from color generator #34

Open TornaxO7 opened 2 years ago

TornaxO7 commented 2 years ago

I'd like to change the constant numbers with constant variable names to make it easier to understand those constant numbers in the color generator. But I don't fully understand what your calculations are doing here:

Could you please explain them a bit and do you agree to move those constants to variables/(named) constants?