search

zestia / ember-select-box

:capital_abcd: A faux select box for Ember apps
MIT License
64 stars 14 forks source link

Add Embroider support #32

Closed ctjhoa closed 3 years ago

ctjhoa commented 3 years ago

Ok I need to rewrite my commits because my npm version is different and the package-lock is fucked up.

amk221 commented 3 years ago

Interesting, thanks for this! We've not had chance to play with Embroider yet.

ctjhoa commented 3 years ago

@amk221 Should be good now

amk221 commented 3 years ago

Thanks, I'm up to speed now.

All passes locally, but not on Travis.

I don't suppose you can make sense of this output: https://travis-ci.org/github/zestia/ember-select-box/jobs/765467368

ctjhoa commented 3 years ago

@amk221 I'm able to reproduce the issue with the CI env variable

CI=true node_modules/.bin/ember try:one embroider-safe
ctjhoa commented 3 years ago

It seems to be a Embroider / qunit bug, you can disable those 2 scenario for the moment if you want.

amk221 commented 3 years ago

Thanks, seeking more help in discord. I can get a release out now though, cheers