search

zestia / ember-select-box

:capital_abcd: A faux select box for Ember apps
MIT License
64 stars 14 forks source link

ci: bump node version to v16 to prevent unresolved deps #62

Closed derrabauke closed 1 year ago

derrabauke commented 1 year ago

The addon is missing the eslint-config-standard peerDep to properly run the linting job.

amk221 commented 1 year ago

It's here, but doesn't seem to be working

derrabauke commented 1 year ago

Alright, got it! :boom:

CI says: 

Environment details
  node: v14.21.3
  npm: 6.14.18

npm prior version 7 will not automatically install peerDependencies.

For npm v4-v6 the following is true :

When a dependency is listed in a package as a peerDependency, it is not automatically installed. Instead, the code that includes the package must include it as its dependency.^1

Upgrading the node version to 16 in the CI should resolve it.

derrabauke commented 1 year ago

Btw: node v14 has reached end of life anyways. One should consider bumping to 18 :thinking:

amk221 commented 1 year ago

thanks for the nudge, running ember-cli-update seems to have mostly solved it.

derrabauke commented 1 year ago

thanks for the nudge, running ember-cli-update seems to have mostly solved it.

Nice! Keep it moving!