search

zestia / ember-select-box

:capital_abcd: A faux select box for Ember apps
MIT License
64 stars 14 forks source link

Added performance test is a bit sketchy #63

Closed derrabauke closed 1 year ago

derrabauke commented 1 year ago

Hey folks! Thanks for the cool addon and the latest refactoring! :clap:

One minor thing came to my mind when I had a look at the currently failig CI:

I think the added performance test is not very meaningful, since you are also testing "how fast can we produce 10.000 array entries". Shouldn't we measure only the time when render-begin to render-end?

Further why add a minimum time for that test?

Cheers

amk221 commented 1 year ago

It's true it could be better, it's very approximate, but it does the job in catching this issue https://github.com/tracked-tools/tracked-built-ins/issues/405, which was all I really wanted.

derrabauke commented 1 year ago

Alright, thanks for the clarification. :+1: