Closed gartnera closed 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
🗂️ Base branches to auto review (1)
* developPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
!!!WARNING!!!
nosec
detected in the following files: cmd/zetaclientd/start.go
Be very careful about using #nosec
in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.
Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: / #nosec G401 / or //#nosec G201 G202 G203
Broad #nosec
annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec
annotations that do not target specific rules.
Pay extra attention to the way #nosec
is being used in the files listed above.
Attention: Patch coverage is 23.88060%
with 51 lines
in your changes missing coverage. Please review.
Project coverage is 64.34%. Comparing base (
f92effb
) to head (ad18cb2
). Report is 1 commits behind head on release/v22.
@gartnera is it acceptable to cherry pick the two commits from https://github.com/zeta-chain/node/pull/3161 to this branch?
@gartnera is it acceptable to cherry pick the two commits from #3161 to this branch?
I see @ws4charlie 's work on https://github.com/zeta-chain/node/pull/3162 replacing https://github.com/zeta-chain/node/pull/3161.
Prepare v22.1.0 release which includes zetaclient TSS updates. This PR should be merged.