search

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
167 stars 109 forks source link

test(e2e): add e2e test for v2 deposit and call with swap #3188

Closed skosito closed 1 week ago

skosito commented 1 week ago

Description

Similar to existing crosschain swap test, but crosschain swap test can't be used with v2 contracts yet. This test can be removed with this issue: https://github.com/zeta-chain/node/issues/2711 but for now its needed to test similar scenario as issue on testnet, where there is a swap and withdraw in onCall function, and cosmos-sdk gas limit for MsgVoteInbound is reached.

This also confirms the fix: https://github.com/zeta-chain/node/pull/3106 - checked locally, without this fix, cosmos sdk 7M gas is drained, because evm gas limit missing is calling eth_estimateGas which spends a lot of cosmos gas.

How Has This Been Tested?

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces a series of updates to the ZetaChain node, including new features for whitelisting SPL tokens on Solana, integration of SPL deposits and withdrawals, and the addition of end-to-end tests for deposit and swap functionalities. It also includes significant refactoring efforts, such as the removal of the HSM signer and simplifications in the zetaclientd configuration. Various fixes address issues within the emissions module, peer discovery mechanisms, and transaction handling, enhancing overall functionality and stability. ## Changes | File Path | Change Summary | |--------------------------------------|--------------------------------------------------------------------------------------------------------| | changelog.md | Updated to reflect new features, improvements, refactoring, fixes, and tests across ZetaChain node. | | cmd/zetae2e/local/v2.go | Added `e2etests.TestV2DepositAndCallSwapName` to `startV2Tests` for ERC20 token workflow testing. | | e2e/contracts/zevmswap/ZEVMSwapApp.*| Added `onCall` function to `ZEVMSwapApp` contract; updated ABI and binary data to reflect this. | | e2e/e2etests/e2etests.go | Introduced constant `TestV2DepositAndCallSwapName` and new E2E test for deposit and call with swap. | | e2e/e2etests/test_v2_deposit_and_call_swap.go | Added `TestV2DepositAndCallSwap` function to validate v2 contracts involving swaps and withdrawals. | ## Possibly related PRs - **#2872**: Changelog updates reflecting significant changes in functionality, including end-to-end tests for deposit and call operations. - **#2895**: Adds an end-to-end test for Bitcoin deposits and calls, related to the comprehensive updates in the main PR. - **#3106**: Introduces `TestDepositAndCallOutOfGasName`, corresponding to the main PR's focus on handling out-of-gas scenarios. - **#3149**: Tests for handling dust amounts in transactions, aligning with the main PR's updates on transaction handling. - **#3162**: Focuses on skipping depositor fee calculations for irrelevant transactions, complementing the main PR's transaction processing improvements. ## Suggested labels `no-changelog`, `SOLANA_TESTS`, `chain:solana` ## Suggested reviewers - fbac - kingpinXD - ws4charlie - brewmaster012 - swift1337 - gartnera - skosito

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
lumtis commented 1 week ago

I'm also thinking maybe we can look into movin the logic in TestDAppV2. To run test on live networks we need contracts that can be put in the config.

But this would be much easier to manage if we have a single test contract we have to deploy for live networks