search

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
167 stars 109 forks source link

test: fix upgrade tests #3196

Closed kingpinXD closed 1 week ago

kingpinXD commented 1 week ago

Description

Fixes the upgrade and upgrade-light tests by making the following changes

How Has This Been Tested?

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces a new command-line flag, `flagSkipBitcoinDustWithdraw`, to facilitate the skipping of specific Bitcoin dust withdrawal tests in local end-to-end testing. This flag is integrated into the existing command structure and modifies the test execution flow accordingly. Additionally, enhancements are made to error logging in several test functions to provide clearer error messages. The overall structure and functionality of the testing framework remain intact, ensuring consistent behavior across tests. ## Changes | File Path | Change Summary | |------------------------------------------------|-------------------------------------------------------------------------------------------------------------| | cmd/zetae2e/local/local.go | Added `flagSkipBitcoinDustWithdraw` flag to skip Bitcoin dust withdrawal tests; modified `localE2ETest` logic accordingly. | | contrib/localnet/orchestrator/start-zetae2e.sh | Updated `start-zetae2e.sh` to include `--skip-bitcoin-dust-withdraw` flag for test execution based on upgrade height. | | e2e/e2etests/test_bitcoin_deposit_and_call_revert_with_dust.go | Added comments to clarify expected behavior of `TestBitcoinDepositAndCallRevertWithDust`. | | e2e/e2etests/test_crosschain_swap.go | Enhanced error logging in `TestCrosschainSwap` to include specific error details from `CreatePair` method. | | e2e/e2etests/test_v2_deposit_and_call_swap.go | Modified error handling in `TestV2DepositAndCallSwap` to log errors without failing the test immediately. | | e2e/e2etests/test_zrc20_swap.go | Improved error logging in `TestZRC20Swap` to provide specific error messages when creating pairs fails. | ## Possibly related PRs - **#2895**: Adds a new end-to-end test for Bitcoin deposits and calls, related to the introduction of the `flagSkipBitcoinDustWithdraw` flag. - **#3142**: Implements a mechanism for handling Bitcoin transactions that revert due to dust amounts, aligning with the main PR's focus. - **#3149**: Enhances handling of transactions involving dust amounts in Bitcoin and Solana, relevant to the main PR's changes. - **#3188**: Introduces an end-to-end test for v2 deposit and call functionality with swaps, relating to broader testing enhancements. ## Suggested labels `UPGRADE_LIGHT_TESTS` ## Suggested reviewers - skosito - ws4charlie - fbac - brewmaster012 - lumtis - swift1337

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
lumtis commented 1 week ago

We should not introduce a flag and make cli more complex for just an edge case

lumtis commented 1 week ago

Removed the flag, we already have the light flag pattern for test to not run in previous version and should reuse this