coderabbitai[bot]
commented
1 month ago 📝 Walkthrough
📝 Walkthrough
## Walkthrough The pull request introduces significant modifications across several contracts, focusing on role management and the handling of the TSS (Threshold Signature Scheme) address. Key updates include granting the `PAUSER_ROLE` to the TSS address in multiple contracts, enhancing the `updateTSSAddress` function to manage role revocations and assignments, and marking the `deposit` function as deprecated. New functionalities for depositing assets and managing custody and connector addresses have also been added, along with updates to the testing contracts to reflect these changes. ## Changes | File | Change Summary | |----------------------------------------|-----------------------------------------------------------------------------------------------------| | `v2/contracts/evm/ERC20Custody.sol` | Updated constructor and `updateTSSAddress` for role management; deprecated `deposit` function. | | `v2/contracts/evm/GatewayEVM.sol` | Modified `initialize` for role assignments; added `depositAndCall`, `setCustody`, and `setConnector` functions. | | `v2/contracts/evm/ZetaConnectorBase.sol` | Constructor updated for role assignment; `updateTSSAddress` remains unchanged. | | `v2/test/ERC20Custody.t.sol` | Introduced `foo` variable for testing; updated access control tests. | | `v2/test/GatewayEVM.t.sol` | Added `foo` variable; modified tests for pause/unpause functionalities. | | `v2/test/ZetaConnectorNative.t.sol` | Added `foo` variable; updated tests for pause/unpause functionalities. | | `v2/test/ZetaConnectorNonNative.t.sol`| Introduced `foo` variable; modified tests for pause/unpause functionalities. | | `v2/test/utils/GatewayEVMUpgradeTest.sol` | Updated `initialize` for role assignment; modified event emissions in `execute` function. | ## Possibly related PRs - **#363**: The changes in this PR directly relate to the `updateTSSAddress` function in the `ERC20Custody` and `GatewayEVM` contracts, which are also modified in the main PR to manage TSS address updates and role assignments. - **#368**: This PR addresses the removal of an unnecessary `_execute` function in `GatewayEVM`, which is relevant as it relates to the overall functionality and management of the TSS address updates in the contract. - **#376**: The modifications in this PR regarding payload size limits in the `GatewayEVM` contract are relevant as they enhance the overall robustness of the contract, which is consistent with the main PR's focus on improving contract functionality and security. - **#385**: This PR focuses on making the `ERC20Custody` and `ZetaConnector` contracts upgradeable, which is directly related to the main PR's changes that enhance role management for the TSS address, ensuring that these functionalities remain intact during upgrades. ## Suggested reviewers - fadeev - CharlieMc0 - andresaiello - brewmaster012 - lumtis - fbacThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov-commenter
add pauser role to tss in all evm contracts
Related to https://github.com/zeta-chain/node/issues/3000
Summary by CodeRabbit
Summary by CodeRabbit
Release Notes
New Features
PAUSER_ROLEandWITHDRAWER_ROLE.Bug Fixes
depositfunction to streamline operations and improve clarity.Tests