search

zeta-chain / protocol-contracts

Protocol contracts implementing the core logic of the protocol, deployed on ZetaChain and on connected chains
MIT License
71 stars 58 forks source link

fix: disable callOnRevert in GatewayEVM call #407

Closed skosito closed 1 month ago

skosito commented 1 month ago

currently not supported on protocol side, so disabling here as well

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@skosito has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Files that changed from the base of the PR and between 48de3a7a6a560da8ec417466e44beb4f4f1f53fb and 4d4c115f601f0e6c9c4096bbf711770a06997b88.
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request include the addition of a new error declaration `CallOnRevertNotSupported()` in the `INotSupportedMethods` interface, enhancing error handling capabilities. Additionally, a new `call` function is introduced in the `GatewayEVM` contract, which allows interaction with omnichain smart contracts without asset transfer and incorporates checks for revert options. Various existing functions have been updated to include checks for payload size and initialization status, improving the robustness of the contract. The test suite has also been updated to reflect these changes, including new test cases and modifications to existing ones. ## Changes | File | Change Summary | |----------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `v2/contracts/Errors.sol` | - Added error: `error CallOnRevertNotSupported()` in interface `INotSupportedMethods`. | | `v2/contracts/evm/GatewayEVM.sol` | - Added method: `function call(address receiver, bytes calldata payload, RevertOptions calldata revertOptions)`.
- Updated methods: `deposit`, `depositAndCall`, `setCustody`, `setConnector` to include new checks for revert options and initialization status. | | `v2/test/GatewayEVM.t.sol` | - Updated contract declaration to include `INotSupportedMethods`.
- Removed `ZETANotSupported` error.
- Modified `setUp` function for revert options.
- Added new test case: `testCallWithPayloadFailsIfCallOnRevertIsTrue`. | ## Possibly related PRs - **#361**: Introduces a new error declaration in the `IGatewayEVMErrors` interface, specifically the `NotAllowedToCallOnRevert` error, related to the new error `CallOnRevertNotSupported()`. - **#376**: Adds a new error `PayloadSizeExceeded`, relevant to changes in the main PR enhancing error handling capabilities in the `GatewayEVM` contract. - **#393**: Introduces the `INotSupportedMethods` interface and the `ZETANotSupported` error, aligning with the new error handling introduced in the main PR. - **#403**: Modifies events emitted during the `WithdrawAndCall` and `DepositAndCall` functions, relevant to changes made in the main PR regarding the `call` function and its error handling. ## Suggested reviewers - fadeev - CharlieMc0 - andresaiello - brewmaster012 - fbac

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.27%. Comparing base (25a6e0b) to head (4d4c115).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #407 +/- ## ========================================== + Coverage 84.23% 84.27% +0.04% ========================================== Files 8 8 Lines 387 388 +1 Branches 122 123 +1 ========================================== + Hits 326 327 +1 Misses 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.