zeta-chain / toolkit

A library of ZetaChain helper utilities, contracts, and Hardhat tasks for smart-contract development
MIT License
43 stars 22 forks source link

Update `hardhat account`, support solana #190

Closed lukema95 closed 3 weeks ago

lukema95 commented 1 month ago

related issue: #187

  1. Support automatic generation of Solana private keys. When using the --save option, store it in the SOLANA_PRIVATE_KEY environment variable in the .env file.
  2. Support recovery using Solana private key when using the --recover option. When ~/.config/solana/id.json exists locally, automatically load that private key. When it doesn't exist locally, users can input the private key in the command line or skip this step.
  3. Maintain backward compatibility. Locally, store PRIVATE_KEY, EVM_PRIVATE_KEY, and BTC_PRIVATE_KEY environment variables in the .env file, and their values are the same.

Summary by CodeRabbit

lukema95 commented 1 month ago
npx hardhat account --save  

    🔑 EVM Private key: 49db34db2e853bda91c17828eb614173573df9ec200bc563217aeb36687f2e0a

    🔑 Solana Private key: 2kP9uN3ySc25UNqhqqTWz5Vt1vRQpcjfgmcJ346NERKaTwUq99nwbVsPg61znaMTnwBHbYyAGnkKRmKgjJhhWq73

    🔐 EVM Mnemonic phrase: level treat gossip actress mistake parent trouble excite wild tone offer time

    😃 EVM address: 0xD7043474A099Cad2a0A3c12F746BA5A9aD74e85f
    😃 Bitcoin address: tb1qg5xxzl4qzn6pgee53a7kjve8lvewk43r8kpcjc
    😃 Bech32 address: zeta16uzrga9qn89d9g9rcyhhg6a94xkhf6zlne0vkz

    😃 Solana address: 2bZFnp4xkrhovr1ahDiuu7D8JxdoaWPyrptF4vDuy7ru
lukema95 commented 1 month ago

@fadeev pls check

fadeev commented 1 month ago

Looking good!

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request introduce functionality for handling Solana wallets in the `account.ts` file, alongside existing support for EVM wallets. A new method, `getSolanaWalletFromLocalFileOrInput`, is added to facilitate wallet retrieval from a configuration file or user input. The `savePrivateKey` function is modified to optionally handle Solana private keys, and various variable names are updated for clarity. Additionally, prompts for user input have been refined to improve user experience. ## Changes | File | Change Summary | |----------------------------------------|-----------------------------------------------------------------------------------------------------------| | packages/tasks/src/account.ts | - Added method `getSolanaWalletFromLocalFileOrInput` for Solana wallet retrieval.
- Updated method signature of `savePrivateKey` to accept an optional `solanaPrivateKey`.
- Modified prompt in `getWalletFromRecoveryInput` for clarity.
- Changed variable names to `evmWallet` and `solanaWallet` in `main` function.
- Enhanced console output for Solana wallet creation. | ## Possibly related PRs - **#185**: The changes in `balances.ts` regarding the handling of Solana private keys and the introduction of new environment variables directly relate to the enhancements made in `account.ts` for managing Solana wallets and private keys. ## Suggested reviewers - fadeev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.