search

zeux / niagara

A Vulkan renderer written from scratch on stream
MIT License
1.26k stars 72 forks source link

VkPhysicalDeviceVulkan12Features shaderFloat16 not supported on Nvidia Maxwell #10

Closed Mebourner closed 2 years ago

Mebourner commented 4 years ago

Awesome stream and git repo, thank you immensely.

One quick note, when running the solution on my Windows 10, NVIDIA 980 Classifieds, the application fails to create a device. While mesh shaders are not supported on this GPU, the non-mesh shader code does work fine, but shaderFloat16 must be disabled.

---
GPU0: GeForce GTX 980
GPU1: GeForce GTX 980
Selected GPU GeForce GTX 980
ERROR: terminator_CreateDevice: Failed in ICD C:\Windows\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_cc8a742077501a9f\.\nvoglv64.dll vkCreateDevicecall
Assertion failed: !"Validation error encountered!", file C:\Programming\Examples\niagara\src\device.cpp, line 76
---

By setting features12.shaderFloat16 = false; the application runs without error. It's not clear to me how it impacts the float16 utilized on the texcoords behind the scene, but it seems to operate acceptably.