Hotfix/exceptions - Githubissues

zfcampus / zf-doctrine-querybuilder

Doctrine Query Builder request Filters

BSD 3-Clause "New" or "Revised" License

32 stars 19 forks source link

Hotfix/exceptions #37

Closed TomHAnderson closed 6 years ago

TomHAnderson commented 7 years ago

For every error in processing filters or order by throw a custom exception.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 86.316% when pulling 4d68059689d7ddf4520cd138a39417a673380419 on TomHAnderson:hotfix/exceptions into c5c483e512020d2964e267b219a67aa4ff41f069 on zfcampus:master.

coveralls commented 7 years ago

Coverage increased (+0.5%) to 86.771% when pulling bfbf9d5a640af5a6c286583452b2f0fecd94ee49 on TomHAnderson:hotfix/exceptions into c5c483e512020d2964e267b219a67aa4ff41f069 on zfcampus:master.

TomHAnderson commented 7 years ago

I'm going to add more detail about which filter failed in the exceptions.

coveralls commented 7 years ago

Coverage decreased (-0.4%) to 85.859% when pulling 466e5d12eb218690b3a961565970b03442347b2e on TomHAnderson:hotfix/exceptions into c5c483e512020d2964e267b219a67aa4ff41f069 on zfcampus:master.

TomHAnderson commented 7 years ago

Ready for merge.

michalbundyra commented 6 years ago

@TomHAnderson have you seen my PR review? Are you going to update this PR?

TomHAnderson commented 6 years ago

For this PR there are a lot of issues and I don't think it's all that necessary or, if it is, it could be written again and I hope better. I gave Exceptions a go but I don't want this to hold up other PRs on this repository so I'll close it and maybe re-address it another time though I hope someone else will give it a go first.