zfcampus / zf-doctrine-querybuilder

Doctrine Query Builder request Filters
BSD 3-Clause "New" or "Revised" License
32 stars 19 forks source link

Extract type cast behaviour #57

Open zluiten opened 5 years ago

zluiten commented 5 years ago

By extracting the type casting to its own class it can be easily replaced when needed. Preferring composition over inheritance etc.

It becomes better testable as well.

I tried to keep BC by proxying to the TypeCaster and instantiating the TypeCaster in the AbstractFilter::getTypeCaster() method when not set in case FilterManager::filter() method is overridden.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-66.2%) to 14.427% when pulling b20a1a0cf296ec374d34033861fd91c2c8e23bf8 on netiul:feature/extract-type-casting into cca97a6f375160660e1305bc610d0fc135b9bd6c on zfcampus:master.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas-api-tools/api-tools-doctrine-querybuilder; a new issue has been opened at https://github.com/laminas-api-tools/api-tools-doctrine-querybuilder/issues/1.

weierophinney commented 4 years ago

This repository has been moved to laminas-api-tools/api-tools-doctrine-querybuilder. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow: