Use version param from route if exists

[kanellov]

I'm having the same problem with @bvarent as described in #8. In order to get over it I've changed the PrototypeRouteListener class in order to use the existing route version param if exists. With this you can specify the placement of the version in the url.

e.g. The following configuration will produce /api/v1/user* urls

$routes = array(
    'api' => array(
        'type' => 'Segment',
        'options' => array(
            'route' => '/api[/v:version]',
        ),
        'child_routes' => array(
            'user' => array(
                'type' => 'Segment',
                    'options' => array(
                        'route' => '/user[/:id]',
                        'defaults' => array(
                            'controller' => 'UserController',
                        ),
                    ),
                ),
            ),
        ),
    ),
);

[kanellov]

php-cs-fixer fails in travis

[TomHAnderson]

I think this is a very poor implementation of what has already been solved using Media Type Versioning. It's like you saw someone else' years-out-of-date API and decided it was easiest enough for you to implement.

https://apigility.org/documentation/api-primer/versioning I can't imagine any scenario where Media Type Versioning isn't superior to url params.

[kanellov]

I agree with you @TomHAnderson, Media Type versioning is better. The change I propose does not affect module's default operation. It just enables the version param positioning in url with the minimum effort.

[TomHAnderson]

Yours is not the easy solution, it is the wrong solution. Just because it's easy doesn't make it right.