Fraction of accreted stars does not add to 1

zhafen / linefinder

A tool for finding and classifying the worldlines of Lagrangian parcels of mass, in the context of hydrodynamic simulations of galaxy formation.

https://zhafen.github.io/linefinder

MIT License

0 stars 1 forks source link

Fraction of accreted stars does not add to 1 #66

Closed zhafen closed 6 years ago

zhafen commented 6 years ago

Originally reported by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

As the title says, the mass of EP + NEP accreted stars doesn't equal 1. So... I need to figure out what's going on.

Idea: My galaxy selection routine in the analysis doesn't have a density cut I don't think... So I need to include that.

Bitbucket: https://bitbucket.org/zhafen/pathfinder/issue/66

zhafen commented 6 years ago

Original comment by Zachary Hafen (Bitbucket: zhafen, GitHub: zhafen)

It's worth noting that it would probably be ideal if the data contained in, e.g., gal_id makes this decision with regards to the density and other criterion too. So I should probably move the density criterion from classify.py to galaxy_find.py.

zhafen commented 6 years ago

This was fixed a while ago.