nus-se-bot
commented
2 years ago Team's Response
No one has that many contacts. MAX_INT is over 2 billion, it does not affect any user since it is unlikely a user will have more than 2 billion contacts to add.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: The problem is not with the number I input. It is with the differing output with the same "correct" input.
I've entered 500 and 111.....1234123, which are both positive integers right? It just so happens that the developers did not take into account the MAX_INT for programming languages.
That's why I raised this issue, I may have accidentally typed in 1111...1234123 but the error messages tells me invalid command format.
If I look at the command format, I would think what I did was correct because "fav" is a valid command and 1111...1234123 is a positive integer. Therefore, I don't know where my problem is, since I don't know that "Positive Integer" stops as 2147483647 for programming languages.
Therefore I will disagree with the team's assessment. It was never about have 2 billion contacts.
There is different output when I put a positive integer greater than Integer.max_int (E.g 999999999999999999999999999999999999999999) versus when i put delete 500 (when there is no 500 contacts). This applies to a lot of different commands such as delete, show, fav, unfav. This might potential be an issue because my command is actually correct and that my index is out of bounds of MAX_INT, but the error message tells me that my formatting is wrong.