kieferro
commented
1 year ago (@johndoknjas I know you're aware of this, but I'm also commenting on it here so it's transparent to other people who find this issue).
Hello, this project is no longer maintained in this repo but on this fork. (For more information about this please look here). Since this issue has no comments, it should be quite easy to copy the content and title into a new issue over there. (For more specific information on that, look here). This makes it easier for us to keep track of things, and it's more convenient because we then have the issues right where they are being worked on. So please create a new issue in the new repo and then close this one. Thank you!
Inspired by issue #113, it's probably best to change a few things about self.depth. Not required per se, but maybe better practice.
Have it be an int instead of a string, which is more intuitive. The few places where self.depth is used in the Stockfish class will need to be updated, as well as any tests referencing self.depth.
Signify self.depth as "private" (so self._depth), and write a public getter function for the user to access it.