search

zhif7782 / 0525-holistic-testing

Feedback for 5/25 Holistic testing.
0 stars 0 forks source link

Calculation allows a value outside of my step #10

Closed dynamicvisionsgis closed 1 year ago

dynamicvisionsgis commented 1 year ago

Describe the bug As a data management control, step value will be important to control the range of values that are acceptable, such as requiring all values to only allow decimals of 0.5 after an integer. If I use the calculate value and put in a value + 5.25, the calculation allows a value to be entered outside of my specified step range. In the example below, the calculation allows the value to be 10.25 but it should only be 10 or 10.5 according to the step parameter I have set.

To Reproduce See screenshots below of settings and result.

image image

Desktop (please complete the following information):

IsmaelInRedlands commented 1 year ago

It seems to me like this behavior is acceptable. One should not be able to enter a value outside of the range (-50 to +50 as shown in the screenshot below), but anything within the range should be acceptable. This is how we have it in the mobile app too. @zhif7782 what do you think? @dynamicvisionsgis Can you describe a specific use case where you think we should reject a value if it does not match the step?

dynamicvisionsgis commented 1 year ago

There have been positions I have held or situations I have been in within scientific studies or data controlled environments where we were to always round to the nearest half or whole number. In data science, I don't believe this is an unreasonable situation, so that is what I thought the step control was taking into consideration so that the data could be managed for quality in those situations with not allowing entries other than what the program requires.

That is all I know. I'm not a hard core advocate of either way you decide to go, but I know there are use cases.

Thanks, Kara E. Utter, MSES, BS Dynamic Visions GIS Portfolio: https://geoidinthesky.wixsite.com/karautter http://geoidinthesky.wixsite.com/karautter Website: https://dynamicvisionsgis.com/my-work/ McCall, Idaho 208.315.4429

On Thu, May 25, 2023 at 11:10 PM Ismael Chivite @.***> wrote:

It seems to me like this behavior is acceptable. One should not be able to enter a value outside of the range (-50 to +50 as shown in the screenshot below), but anything within the range should be acceptable. This is how we have it in the mobile app too. @zhif7782 https://github.com/zhif7782 what do you think? @dynamicvisionsgis https://github.com/dynamicvisionsgis Can you describe a specific use case where you think we should reject a value if it does not match the step?

— Reply to this email directly, view it on GitHub https://github.com/zhif7782/0525-holistic-testing/issues/10#issuecomment-1563817963, or unsubscribe https://github.com/notifications/unsubscribe-auth/BADFOFSVJ2CDD3H7A2ISVRTXIA3LHANCNFSM6AAAAAAYPDFHFI . You are receiving this because you were mentioned.Message ID: @.***>

IsmaelInRedlands commented 1 year ago

@dynamicvisionsgis Thanks a lot for the details. This is useful. For now, we are going to allow calculations to set any value within the range. We feel enforcing the interval to be matched will cause issues in other workflows. Ideally, the author will configure a calculation with rounding according to their specs.