search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Overfilling your cargo gives a bogus error message #29

Closed ryllae closed 5 years ago

ryllae commented 5 years ago

Drag an excessive volume of items to your cargohold, and you get an improperly formatted error message. This appears often when moving multiple stacks of multiple items: Capture20

zhyrohaad commented 5 years ago

i have noticed this, but cannot consistently reproduce, which makes it hard to track. i do have it on the list to look into, when i find it.

this msg is one of the multitude "preprogrammed" client error msgs i have recently (within past year) implemented, and have not fully tested.

zhyrohaad commented 5 years ago

fixed and main is updated pls test to verify

ryllae commented 5 years ago

Still a bug. Best way to reproduce: In an Orca, add metric ton of Veldspar to your Cargo Hold (this may violate your actual space). Drag the entire stack to the 1nd Division tab.

You can also do this easily between division tabs.

If you first try to drag to the OreHold first, you can encounter https://github.com/zhyrohaad/AlasiyaEvE/issues/37, creating smaller stacks, then subsequently move SOME of the ore before hitting this bug? Reason is not clear.

There are also ways to trigger this without the Division tabs and just use the orehold and cargo hold, but it takes more setup.

zhyrohaad commented 5 years ago

single stacks work as intended (deliberate error on jetcan capy) 2019 09 02 06 24 33 2019 09 02 06 24 41 2019 09 02 06 24 57

zhyrohaad commented 5 years ago

nm. found it. took a bit of playing, but found and working on a fix. also looking into why the capy checks arent working for corp hangars and other containers. will post when fixed and updated.

zhyrohaad commented 5 years ago

found errors and missing checks/data for inventory tests. this has been rewritten and corrected. main is now running this updated code.

ryllae commented 5 years ago

Found other bugs, but not this one. Assuming we're good here.