search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Giving ISK to a corporation doesn't update its Balance #45

Open ryllae opened 5 years ago

ryllae commented 5 years ago

Open the Corporation Wallet tab. Give some ISK. Balance still says $0 (or whatever it said previously). Reopening the window refreshes the correct value.

zhyrohaad commented 5 years ago

there is an update missing with this to tell client the data has changed, but i havent found it yet. however, when opening the window, the client will request a data refresh from server.

zhyrohaad commented 5 years ago

this is part of a semi-core system rewrite. this particular system is currently goes like this..... send update msg for corp A. loop thru ALL connected players check for player corp == corp A if so, check for corp roles >= [role needed for this update] (this is only sometimes) if so, send update.

this is one of the systems i havent really messed with until recently. i am currently rewriting it to remove the crazy loop and checks new system is designed to have separate corp maps of player and corp role, to allow searching for specific roles or players for updates. there are a few calls that use this new system, but not many at this time.

update 23Mar21 this core rewrite was completed a while back. (over a year ago) new system goes like this.... generate update msg for corp A. query corp lists for online players for corp A check role == [role to be notified] send update to affected/interested players.

zhyrohaad commented 3 years ago

obviously, i havent looked at this in a while. this 'new' system was last updated over a year ago, with multiple corp msgs/roles implemented. i do not yet have a list of completed/working corp notifications, but accounting is one of them.