search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Depleting Asteroid causes segfault when mining cycle ends #52

Closed zhyrohaad closed 4 years ago

zhyrohaad commented 5 years ago

Describe the bug see title

To Reproduce mine all available ore from asteroid

Expected behavior ore moved into hold, mining laser stops after cycle completes

zhyrohaad commented 5 years ago

(treating this as any other bug report, i am commenting as i would any other) this system hasnt been discussed much, and since we've lost the post about it on forums, i'll dive a bit deeper here. (i'll recreate the forum post eventually) target manager does just that......manages targets. this system is simple, but the code gets complicated. it deals with all possible actions dealing with items being targetted, and even tracks what modules on which ships are active on a given target. all SystemEntities (any item in space) have a targetMgr. when an SE is destroyed, a call is made to all ships targetting this item, as well as all modules currently active on this item. there are multiple calls to targetMgr that have to be in order, mostly because the system hasnt been optimized yet to self-call all needed methods to complete the task it should be doing. this particular call was missing when asteroids were depleted.

it is fixed now. currently undergoing testing.

ryllae commented 5 years ago

Can also report that Salvaging causes a segfault upon success.

zhyrohaad commented 5 years ago

found few other errors with mining while debugging this segfault. currently working on dev server.
polishing and gonna push to main for more testing

salvage error should be separate issue.

zhyrohaad commented 4 years ago

main updated. will test when time permits

ryllae commented 4 years ago

Still crashes with strip miners.

zhyrohaad commented 4 years ago

ok. i'll dig into it when i can.

zhyrohaad commented 4 years ago

working. main updated with fix