search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Docking while acquiring mutual locks on a hostile causes a segfault #75

Closed ryllae closed 4 years ago

ryllae commented 4 years ago

Undock a large ship (say, a Raven Navy Issue). .spawn 13645 20. Immediately start acquiring a lock on several targets. As soon as they attempt to target you back, dock up. .

Not sure if the crashing is coming from me or them.

zhyrohaad commented 4 years ago

whoa....wtf? there is code in targetMgr that checks for presence of target. systemMgr, bubbleMgr and destinyMgr verify ALL object positioning (yes, 3-way independent redundancy), and communicate with all other managers when changes occur. this means the error you report should never happen. since you're reporting it, i have some major problems in my manager communication or something else hell, even when a ship docks, it tells EVERYBODY it's docking, so this should NEVER happen.

i'll look at server logs and run some tests and report back when i know something

zhyrohaad commented 4 years ago

found problem and coded fix main updated the 'ship docking' code was commented out with a note calling to "fix this shit later"

nice.

ryllae commented 4 years ago

zhyrohaad:

Better now.

ryllae commented 4 years ago

Same problem. Spawn some rats, let them start targeting you, dock up for a segfault. Works ok if they have acquired the lock.

zhyrohaad commented 4 years ago

Ok so in this case, it's the TargMgr that isn't getting the "I'm docking, asshole" msg. I'm not sure if that particular action is passed to targeting system or not. Now that I think about it, it very well should be, cause players can target docking ships too. This also needs more work.

zhyrohaad commented 4 years ago

as noted in #108, this seems to be working as intended, and main server has been updated.

ryllae commented 4 years ago

Looks good again.