search

zhyrohaad / AlasiyaEvE

Public repo for bug tracking the private Alasiya-EvE codebase
2 stars 0 forks source link

Propulsion mods are not behaving #81

Open ryllae opened 4 years ago

ryllae commented 4 years ago

Describe the bug Afterburners do not change your speed when activated.

Also, if toggled off while running, they don't stop after making a full rotation (Afterburner skill training L5 interaction? This could be expected Crucible UI behavior, I don't know).

To Reproduce Equip a 10MN Afterburner on a Hawk. Undock, push your afterburner. .bubblelist shows your speed hasn't changed.

ryllae commented 4 years ago

Microwarp drives appear to be doing nothing either. Perhaps propulsion mods need attention. I can't duplicate #12 or #13 at the moment until prop mods actual make you go faster or slower 🤷‍♂

zhyrohaad commented 4 years ago

they use same code. they shouldnt. its' on the list.

zhyrohaad commented 4 years ago

found what the error is. no clue on why the error is, or how to fix it yet.

update (edited) found errors in effects code, with ab/mwd the most obvious. reworked logic and corrected errors. testing fix.

zhyrohaad commented 4 years ago

fixed and updated

ryllae commented 4 years ago

I equipped a new 10MN Afterburner on my Hawk, and it still has no effect on my speed (as confirmed by .bubblelist). Same with a 1MW Microwarp drive. I move at 341.3m/s, my standard speed, no matter what I push.

I might have seen a few cases where it looks like I momentarily was accelerating from stop back to 341, but I've also seen NAN randomly from .bubblelist if I invoke it too quickly? This aside, prop mods are still busted.

zhyrohaad commented 4 years ago

There is a single second delay between activation and update on purpose in server code to try to match client visuals. This may be the reason you see funny things if invoked "too fast". However, that still shouldn't happen.

zhyrohaad commented 4 years ago

touch

ryllae commented 4 years ago

Tested on dev eb777b: Afterburners and Microwarp drives appear to have no effect on speed (visiually or via .bubblelist).

zhyrohaad commented 4 years ago

this has been updated. there is still few desyncs when using ab/mwd, but working better. the remainder will be finished at a later date

ryllae commented 4 years ago

Neither my 1MN AB nor my 1MN MWD have any effect on my Hawk's speed.

I can also enable both at once, which isn't expected. I still don't go any faster.

ryllae commented 3 years ago

Neither AB nor MWD seem to have any effect

zhyrohaad commented 3 years ago

hasnt been touched since last year. is on list with destiny problems