search

ziflex / lecho

Zerolog wrapper for Echo framework 🍅
MIT License
97 stars 11 forks source link

Add request latency log escalation #31

Closed jlsherrill closed 4 months ago

jlsherrill commented 4 months ago

This adds the ability to specify a duration and a log level within the config. If a given request takes longer than the specified duration, it will be logged at this new level.

ziflex commented 4 months ago

Hi @jlsherrill thank you for your PR!

Could you add test coverage and the description of the new settings to README.md, please?

jlsherrill commented 4 months ago

added!

ziflex commented 4 months ago

Great! I apologize, you had seen my message before I edited it. Could you, please, add unit tests as well?

jlsherrill commented 4 months ago

added, let me know if you want me to break that test up into two

ziflex commented 4 months ago

That would be nice.

jlsherrill commented 4 months ago

test is now split

jlsherrill commented 4 months ago

oh and hi from Cary !

ziflex commented 4 months ago

Hello from Raleigh and thank you for your contribution!