zigpy / zha-device-handlers

ZHA device handlers bridge the functionality gap created when manufacturers deviate from the ZCL specification, handling deviations and exceptions by parsing custom messages to and from Zigbee devices.
Apache License 2.0
689 stars 639 forks source link

[Device Support Request] for Lidl Christmas led string HG0646 #1933

Open erkr opened 1 year ago

erkr commented 1 year ago

Please add a quirk to support the melinera HG06467 Christmas light strings sold by the LIDL.

The strings are supported by Z2M: https://www.zigbee2mqtt.io/devices/HG06467.html

And there exists an issue for this that became stale. That issue contains all information wrt these Christmas led strings: https://github.com/zigpy/zha-device-handlers/issues/604

Best Eric

MattWestb commented 1 year ago

Hola @javicalle !!

If you have time this device is very wanted for the moment and is one real "tuya hybrid" that is using normal Zigbee commands and some very tuya cooked ones.

In ground is one normal light that have pixel LEDs and the normal lights things is Zigbe commands and the pixel is having some special commands implanted.

I have not baying it then is was little over my budged but many users have doing it.

If you have time and can taking one look may user wold getting one nice Christmases if you can cocking one quirk for it.

Mvh Mattias

rkruisselbrink commented 1 year ago

Is there anything we can do to help with this effort? I have this product as well and it would be awesome to control the effects via ZHA 🎄

erkr commented 1 year ago

I can help to test with local quirks. Wife is not happy😱

erkr commented 1 year ago

A lot of time left before Christmas 😉

MattWestb commented 1 year ago

@TheJulianJES We was trying getting one of this to our US friends for2 years ago but we was not getting any that was willing baying and shipping it from Europe. If you is getting one or some else in CE is having one and can getting it to you can you taking one look getting one working quirk for it ? I think its one normal RGB light plus extra scenes for searing the pixel LEDs with tuya MCU commands.

MattWestb commented 1 year ago

For users that having one of this "devices" and need it working next Christmas is the devs needing getting hand of one for testing and doing the coding.

In CE we have great quirk devs in Germany and in Spain and probably more if we asking little more around.

Pleas helping getting the beloved device working by sharing hardware for some time and getting it working with our systems.

Thanks in advance !!!

xanibale commented 1 year ago

I am from Germany and have this Device, i would be willing to send it to any quirk dev, preferable in Germany, for some time.

MattWestb commented 1 year ago

Great @xanibale I pinging @TheJulianJES hi is located in Ger and have the knowledge and if need hi is getting help from our US or Spanish devs.

I hoping for the next Christmas shall being white with much colors in the (dev)tree !!!

TheJulianJES commented 1 year ago

At the moment, I don't have enough time to work on a (Tuya) device with a given time limit.

It'll also be hard to implement the effects properly and ZHA (HA Core) would probably also need to be modified for this.

xanibale commented 1 year ago

If i would get it back until next Christmas, then there should be no problem, as it is now not usable for me anyway. It would be very nice to use the colour/ white capabilities of the device. If that would make things easier.

erkr commented 1 year ago

Yes, first fixing normal colour and brightness control would be a great step. Now the colours change when the brightness is adjusted.

erkr commented 1 year ago

Christmas seem still far away, but we are 6 months further 🙏

rkruisselbrink commented 11 months ago

I was also thinking about this. Is there some guide or docs on how we can test/debug this? I'm willing to give it a shot and spent some time on this, but i have no idea where to start 😅

d3nnis0 commented 9 months ago

I also own the those Christmas lights and I'am willing to invest some time to get them integrated until Christmas (Or even better some weeks before ;-) )

Is there already a kind of draft where I can try to contribute?

rkruisselbrink commented 8 months ago

Is there already a kind of draft where I can try to contribute?

Not that i know of. Any idea how to approach this?

erkr commented 8 months ago

I noticed that the Christmas lights where added to the Deconz integration: https://github.com/Kane610/deconz/issues/198

I hope some expert knows how to translate the information that seems to be available there into a handler for ZHA

Hedda commented 7 months ago

I noticed that the Christmas lights where added to the Deconz integration: Kane610/deconz#198

I hope some expert knows how to translate the information that seems to be available there into a handler for ZHA

FYI, for development reference, the developer of the deCONZ integration for Home Assistant also added "effects" and "colors" support for HG06467 (Zigbee ID "TS0601") Lidl Silvercrest Christmas light to Home Assistant's deCONZ integration now too:

https://github.com/home-assistant/core/pull/102731 -> https://github.com/home-assistant/core/pull/102731/commits/d58dcd179ec322602afb74ee909bde93fbbdf022

https://github.com/home-assistant/core/pull/105155 -> https://github.com/home-assistant/core/pull/105155/commits/fecdb6c20fd78d45007a483e76920bfbb3a27ed2

https://community.home-assistant.io/t/lidl-melinera-christmas-string-hg06467-lidl-livarno-lux/367

https://community.home-assistant.io/t/update-deconz-integration-to-support-flash-with-color/246904/

PS: For more reference, same "effect" and "color" support for Lidl Malinera "Smart LED String Lights" HG06467 (Zigbee ID "TS0601") was added to zigbee-herdsman-converters for Zigbee2MQTT back in 2020 and these are their pull request and discussions about it:

https://github.com/Koenkk/zigbee-herdsman-converters/pull/1799

https://github.com/Koenkk/zigbee-herdsman-converters/issues/1792

https://zigbee2mqtt.discourse.group/t/lidl-christmas-lights/1788/

https://github.com/Koenkk/zigbee2mqtt/issues/5221

enyone commented 7 months ago

I tried to hack something together last year this same time (one week before Christmas). My neighbors are still not happy so also I am keen to debug any contributions to this draft.

https://gist.github.com/enyone/e1e0182f41ab9924d33fd24d77765aa6

See that 0xFC: foundation.ZCLCommandDef(... I created to issue effect change command and a handler for that if command_id == 0x00FC: with a static data tuya_payload.data = [0x00, 0x0A, 0x30, 0x31, 0x30, 0x30, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40] to play around.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

rkruisselbrink commented 1 month ago

I think we want to keep this open. I didn't have (make) time yet to checkout the implementation by @enyone