search

zijiechenrobotics / ig_lio

iG-LIO: An Incremental GICP-based Tightly-coupled LiDAR-inertial Odometry
GNU General Public License v2.0
355 stars 48 forks source link

support cmake install targets #8

Closed juliangaal closed 5 months ago

juliangaal commented 5 months ago

Allows for catkin_make install to work as expected

Additionally, -Wall is now only applied to your own code, as 

include_directories(SYSTEM
  ${catkin_INCLUDE_DIRS}    
)

is marked as a system directory, and therefore ignored.

The only change I would suggest before merging: because the result folder does not exist after catkin_make install one would have to create the result for manually, or in ig_lio_node.cpp. I am willing to implement that as part of this PR. What do you think?

zijiechenrobotics commented 5 months ago

Thank you for the contribution to iG-LIO 🤩

juliangaal commented 5 months ago

The only change I would suggest before merging: because the result folder does not exist after catkin_make install one would have to create the result for manually, or in ig_lio_node.cpp. I am willing to implement that as part of this PR. What do you think?

Now available in #9

zijiechenrobotics commented 5 months ago

The only change I would suggest before merging: because the result folder does not exist after catkin_make install one would have to create the result for manually, or in ig_lio_node.cpp. I am willing to implement that as part of this PR. What do you think?

Now available in #9

Sorry, I didn't read your comments carefully. It is true that not creating a "result" folder is a bug. Thank you for your careful reminder.