search

zikula-modules / FAQ

Frequently Asked Questions
http://code.zikula.org/faq
8 stars 1 forks source link

Undefined Variable "dom" - FAQ 2.3.3 - Installation #11

Open ghost opened 7 years ago

ghost commented 7 years ago

Hello Developers,

Unfortunately I can not install the module FAQ again. I already take the last updated module version, but Errors always show "undefined variable - DOM".

How can I remove it or install it better?

Thanks in advance.

P.S. I had to reinstall because of a serious error Zikula 1.4.6 completely. Therefore always the module installation.

ghost commented 7 years ago

Ok, I have now removed $dom from Installer.php and could install the module. I just hope that it does not affect the work of the module in the frontend or the backend.

I see this when I create first FAQs.

craigh commented 7 years ago

I think remove all instances of $dom in the installer is the proper solution. could you submit a PR?

ghost commented 7 years ago

OK! What is meant by "PR"?

craigh commented 7 years ago

sorry, I assumed you had more experience with github - I mean a Pull Request - which means, you alter the code and submit that back to the repository for merge. If this is not familiar to you, then maybe we can discuss it in detail another time.

ghost commented 7 years ago

As far as I was not yet, that I create PullRequests. So far I collected first experiences with the Git with Bitbucket Server on the root server and just the simple thing the Forks.